Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Kangheui Won, Paul Menzel, Zheng Bao, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59308 )
Change subject: amdfwtool: Upgrade "relative address" to four address modes ......................................................................
Patch Set 4:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133528): https://review.coreboot.org/c/coreboot/+/59308/comment/0ace3031_cb705916 PS4, Line 355: ((mode) == 2 ? (offset) - ctx.current_table : (offset)) )) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133528): https://review.coreboot.org/c/coreboot/+/59308/comment/50d5a380_1559496c PS4, Line 357: #define RUN_TO_OFFSET(ctx, run) ((ctx).address_mode == 0 ? (run) - RUN_BASE(ctx) : (run)) /* TODO: */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133528): https://review.coreboot.org/c/coreboot/+/59308/comment/bd26a201_8ea64df3 PS4, Line 478: bdir->header.additional_info_fields.dir_size = table_size / 0x1000;; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133528): https://review.coreboot.org/c/coreboot/+/59308/comment/7bef7379_1ff6f1b5 PS4, Line 955: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133528): https://review.coreboot.org/c/coreboot/+/59308/comment/43a62f37_1f5f7370 PS4, Line 961: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133528): https://review.coreboot.org/c/coreboot/+/59308/comment/24582236_fa1e2600 PS4, Line 974: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters