Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM ......................................................................
Patch Set 15:
(3 comments)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/2cc5af00_2d3373c1 PS12, Line 179: min_pci_d_states
This is actually what I started with. […]
Implemented in patch set #15
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/abdb1368_56143ee0 PS13, Line 116: typedef enum { : D0, /* 0 */ : D1, /* 1 */ : D2, /* 2 */ : D3, /* 3 */ : UNDEF : } D_STATES;
Ack […]
I didn't ultimately use it as it also it doesn't seem safe as it also has unsupported values (ACPI_DEVICE_SLEEP_D3_COLD).
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/7da9a236_29b8f90e PS15, Line 260: break; Oops. redundant. Will delete.