build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34537/14/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/34537/14/src/device/pci_device.c@77... PS14, Line 773: if(vbe_mode_info_valid()){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/34537/14/src/device/pci_device.c@77... PS14, Line 773: if(vbe_mode_info_valid()){ space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/34537/14/src/device/pci_device.c@77... PS14, Line 778: unsigned char *framebuffer = (unsigned char *)le32_to_cpu(mode_info.vesa.phys_base_ptr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34537/14/src/lib/bootsplash.h File src/lib/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/34537/14/src/lib/bootsplash.h@25 PS14, Line 25: unsigned int y_resolution, unsigned int fb_resolution); adding a line without newline at end of file