build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59370 )
Change subject: [WIP]soc/amd/mendocino: Add mendocino and mainboard ......................................................................
Patch Set 2:
(12 comments)
File src/soc/amd/mendocino/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/84cdf5bf_9b831261 PS2, Line 109: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/49c38ba2_02f6dd20 PS2, Line 122: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
File src/soc/amd/mendocino/psp_verstage/svc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/fec12567_aa28c5cd PS2, Line 6: #define SVC_CALL4(SVC_ID, R0, R1, R2, R3, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/0766befa_4e479565 PS2, Line 19: #define SVC_CALL3(SVC_ID, R0, R1, R2, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/a7a1b234_6a2e4859 PS2, Line 30: #define SVC_CALL2(SVC_ID, R0, R1, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/94fdc647_7065f721 PS2, Line 40: #define SVC_CALL1(SVC_ID, R0, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/2a657f7c_04fab1a2 PS2, Line 49: #define SVC_CALL0(SVC_ID, Ret) \ Macros with complex values should be enclosed in parentheses
File src/soc/amd/mendocino/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/e5717be1_f410c829 PS2, Line 72: * | | X86_RESET_VECTOR = BOOTBLOCK_END - 0x10 line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/1656a2b2_f3448ac4 PS2, Line 75: * +--------------------------------+ BOOTBLOCK_ADDR = BOOTBLOCK_END - C_ENV_BOOTBLOCK_SIZE line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/806d59db_29598d17 PS2, Line 80: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE + 0x200 line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/4e3d958d_600a8786 PS2, Line 82: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133550): https://review.coreboot.org/c/coreboot/+/59370/comment/8f9506b7_b900748f PS2, Line 85: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE line over 96 characters