build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42831 )
Change subject: soc/amd/picasso: Use cbfs to locate the AMD firmware
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42831/4/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42831/4/src/soc/amd/picasso/psp_ver...
PS4, Line 44: if (cbfs_locate(&fh, rdev, name, &type)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/42831/4/src/soc/amd/picasso/psp_ver...
PS4, Line 78: if (fmap_locate_area_as_rdev(rname, &rdev)){
space required before the open brace '{'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27b0593e0db7a9e6ba9b0633ac93b4d93954f002
Gerrit-Change-Number: 42831
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 21:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment