[coreboot-gerrit] [S] Change in coreboot[main]: [RFC] ec/google/chromeec: Guard reading long battery strings

[Peter Marheine (Code Review)]

Attention is currently required from: Forest Mittelberg, Matt DeVillier.

Peter Marheine has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84300?usp=email )

Change subject: [RFC] ec/google/chromeec: Guard reading long battery strings
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> Bisected to find the commit, then reverted to confirm. […]

Google doesn't support any devices (well, any devices that use ACPI) which lack a GSC anymore, so checking the presence of a GSC seems fine to me.

We wouldn't want to accidentally disable this on new platforms though, so perhaps it would be reasonable to disable this by listing the boards that it breaks and disabling it on those specifically, or check for the more general `TPM_GOOGLE` config if that's not reasonable (to guard against a newer driver appearing).