Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43510 )
Change subject: tests: Add lib/bootmem-test test case
......................................................................
Patch Set 2:
In v2 beside addressing review comments, I also fixed an issue with unit-test failing on Jenkins. It turns out, that newer (at least newer than the version I'm using on my machine) gcc versions are enabling PIE by default. This, combined with the fact that ASLR is applied for all position independent executables, makes my linker script with constant addresses for symbols useless.
In order to overcome above, I've added -no-pie option for bootmem-test compilation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1e539061ee5051d4158712a8a981a475ea7458a
Gerrit-Change-Number: 43510
Gerrit-PatchSet: 2
Gerrit-Owner: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Jul 2020 22:19:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment