Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40484 )
Change subject: nb/amd/agesa: read 256 bytes to SPD buffer instead of 128 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40484/1/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/dimmSpd.c:
https://review.coreboot.org/c/coreboot/+/40484/1/src/northbridge/amd/agesa/f... PS1, Line 44: int err = smbus_readSpd(spdAddress, (void *) info->Buffer, 256);
Some of the boards may rely on 128 bytes of SPD. […]
I can't find any boards which have CONFIG_DIMM_SPD_SIZE defined as 128, but even if those existed (contrary to JEDEC spec), the extra read bytes will be simply unused and won't hurt.