Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47483 )
Change subject: [WIP] soc/amd/common: factor out SMU code from Picasso
......................................................................
Patch Set 1:
I'm not too happy about how I get the PCI device (that at least on the APUs will likely always be function 0 of device 0 on bus 0) that is used to access the SMU mailbox; if you have a better idea, please let me know
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf5b91ab35428e4c771e7163c6e0c4fc50371e7
Gerrit-Change-Number: 47483
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Wed, 11 Nov 2020 23:36:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment