Attention is currently required from: Raul Rangel, Nico Huber, Patrick Georgi, Kyösti Mälkki. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 )
Change subject: console: Add loglevel prefix to interactive consoles ......................................................................
Patch Set 3:
(3 comments)
File src/commonlib/include/commonlib/loglevel.h:
https://review.coreboot.org/c/coreboot/+/61306/comment/79715c51_6bded319 PS3, Line 170: EMERG
Maybe we can add color codes too! […]
Right... see the next commit message on why I experimented with but in the end chose not to use color. I want this to "just work" for people without having to understand the details or futz with their terminal, so this seemed like the most reliable way to do it. Also, the problem with color is always that everyone has different terminal preferences, and you can't pick a color scheme that looks good on all backgrounds.
If there's enough interest someone could certainly easily add a color option behind a separate Kconfig. Would probably make sense to have at least a "light" and a "dark" theme, then.
File src/console/console.c:
https://review.coreboot.org/c/coreboot/+/61306/comment/f2fdc53a_de86165e PS3, Line 27: line_start
Let's move this function into printk.c (wrap_putchar). […]
No, I don't think that works... I'm trying to deliberately make a distinction between "interactive" and "stored" consoles here, so I don't waste our tight CBMEM console buffers by printing the whole "[DEBUG] " in every line. This file is the only one that has distinction between the underlying consoles, so I think I need to put it here.
https://review.coreboot.org/c/coreboot/+/61306/comment/244314ba_48f59923 PS3, Line 60: 0
nit: false
Oops, right. Done.