Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41690 )
Change subject: mb/ocp/deltalake: Config PCH PCIe ports in devicetree ......................................................................
Patch Set 15: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/41690/14/src/mainboard/ocp/deltalak... File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/41690/14/src/mainboard/ocp/deltalak... PS14, Line 85: mupd->FspmConfig.PchPcieForceEnable[index] = 0;
Done
Relevant to the last comment from Patchset 15 https://review.coreboot.org/c/coreboot/+/41690/15/src/mainboard/ocp/deltalak...
https://review.coreboot.org/c/coreboot/+/41690/15/src/mainboard/ocp/deltalak... File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/41690/15/src/mainboard/ocp/deltalak... PS15, Line 83: : /* Set PchPcieForceEnable to disable by default */ : mupd->FspmConfig.PchPcieForceEnable[index] = 0; : : if (config->pch_pci_port[index].ForceEnable) { : mupd->FspmConfig.PchPcieForceEnable[index] = : config->pch_pci_port[index].ForceEnable; : mupd->FspmConfig.PchPciePortLinkSpeed[index] = : config->pch_pci_port[index].PortLinkSpeed; : } Use
mupd->FspmConfig.PchPcieForceEnable[index] = config->pch_pci_port[index].ForceEnable; mupd->FspmConfig.PchPciePortLinkSpeed[index] = config->pch_pci_port[index].PortLinkSpeed;
instead of this code.
ForceEnable is set to 0 if we don't set it in the devicetree. No need to take care of it here.