Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47171 )
Change subject: soc/intel/xeon_sp/skx: Reorder soc_util.c
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47171/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47171/2//COMMIT_MSG@7
PS2, Line 7: Reorder soc_util.c
With BUILD_TIMELESS=1 the binaries don't match so this is not a simple reordering.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47171
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab343e903e2478709fe91739c9ca77f587286df7
Gerrit-Change-Number: 47171
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment