Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83830?usp=email )
Change subject: commonlib/bsd: Add strlen() and strnlen() functions
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
This patch broke siemens/mc_ehl mainboards with enabled measured boot (TPM_MEASURED_BOOT). […]
Thanks for reporting. I think I found the problem. See the other open comment of mine. I'll try to fix it tomorrow.
File src/commonlib/bsd/string.c:
https://review.coreboot.org/c/coreboot/+/83830/comment/0c68069e_736f6d34?usp... :
PS3, Line 16: maxlen
console/vtxprintf.c may pass `(size_t)(-1)` here, so the `end` pointer may overflow, causing this function to return 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83830?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1203ec9affabe493bd14b46662d212b08240cced
Gerrit-Change-Number: 83830
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Comment-Date: Wed, 14 Aug 2024 08:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com