Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36939 )
Change subject: cbfs: switch to region_device for location APIs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36939/1/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/36939/1/src/lib/cbfs.c@289
PS1, Line 289: region_device_offset(rdev), region_device_sz(rdev));
nit: This is pretty redundant anyway considering that cbfs_boot_region_device() prints it again, rig […]
Ya. I was noticing that as well. I wasn't trying to remove the prints in this patch. I wanted to do a straight change of the types.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0158a095cc64c9900d8738f8ffd45ae4040575ea
Gerrit-Change-Number: 36939
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 18 Nov 2019 23:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment