wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31519 )
Change subject: mediatek/mt8183: Modify I2C source clock
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31519/1/src/soc/mediatek/mt8183/pll.c
File src/soc/mediatek/mt8183/pll.c:
https://review.coreboot.org/#/c/31519/1/src/soc/mediatek/mt8183/pll.c@349
PS1, Line 349: 0x1 << 11
can we revise the magic numbers here? for example name 0x1 as something with TOPCKGEN
I just modeled the above code. If you think a macro definition is better, I will modify it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49e0acda22dba449d0873a95ba5fae79a9cef569
Gerrit-Change-Number: 31519
Gerrit-PatchSet: 1
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wang qii
Qii.Wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Fri, 22 Feb 2019 03:03:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment