Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31979 )
Change subject: soc/nvidia/tegra{124,210}: Use 'halt()' already defined in <halt.h> ......................................................................
Patch Set 1:
It looks like Jenkins doesn't flag this because the coreboot build system doesn't build this at all. I guess we could change that if we want to (just having a target to call '$(MAKE) -C .../lp0/ and adding that as a prerequisite somewhere should be enough), but that would also be a little weird because this is technically not a prerequisite for the firmware image. For reference, the way Chromium OS builds this is with a separate ebuild (independent of coreboot) here https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/r... , and then the resulting binary must be installed to the disk under /lib/firmware to be picked up by Linux. (So really, if you ask me this is a Linux thing, not a coreboot thing, but when we tried to upstream it the Linux maintainers thought differently. It is used during S3 resume.)
Alternatively, we can also remove it from the tree, but then that means this code isn't publicly hosted anywhere at more which would also be unfortunate.