Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )
Change subject: util: Add spd_tools to generate SPDs for TGL boards ......................................................................
Patch Set 5:
(3 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/44429/4/util/spd_tools/intel/ddr4/g... File util/spd_tools/intel/ddr4/global_ddr4_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/44429/4/util/spd_tools/intel/ddr4/g... PS4, Line 7: "bankGroups": 4, Should be 2 banks for 512Mb x 16.
https://review.coreboot.org/c/coreboot/+/44429/4/util/spd_tools/intel/ddr4/g... PS4, Line 24: "pageSize": 4, Some data sheets state "Page size = 2COLBITS × ORG/8". Can we derive page size this way?
https://review.coreboot.org/c/coreboot/+/44429/4/util/spd_tools/intel/ddr4/g... PS4, Line 38: "pageSize": 2, Page size should be 2KB (4 512B). Perhaps the format for this attribute should be 512B, 1KB or 2KB.