Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31255 )
Change subject: cpu/intel/model_1067x: Check for lock bit on IA32_FEATURE_CONTROL ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31255/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31255/4//COMMIT_MSG@9 PS4, Line 9: " cpu/intel Remove the space after "?
https://review.coreboot.org/#/c/31255/4/src/cpu/intel/model_1067x/mp_init.c File src/cpu/intel/model_1067x/mp_init.c:
https://review.coreboot.org/#/c/31255/4/src/cpu/intel/model_1067x/mp_init.c@... PS4, Line 66: printk(BIOS_DEBUG, "IA32_FEATURE_CONTROL already locked\n"); Is that expected? If not, a lower log level like NOTICE might be useful.