Attention is currently required from: Arthur Heymans, Bao Zheng, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69783?usp=email )
Change subject: smm: Invalid the smm handler region instead of the whole
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/cpu/smm/smm_relocate.c:
https://review.coreboot.org/c/coreboot/+/69783/comment/70577ffe_032c0774 :
PS4, Line 85: tseg_valid();
: lock_smm();
Maybe you want to move this later in the bootprocess?
https://review.coreboot.org/c/coreboot/+/64871/comments/42ed8bbb_f4efd5eb
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69783?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cd422f35b3dfa25ae8ed8034f05f8d47350fd6e
Gerrit-Change-Number: 69783
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 20:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment