[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186

[Hung-Te Lin (Code Review)]

Attention is currently required from: Knox Chiou, Paul Menzel, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu.

Hung-Te Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )

Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................

Patch Set 8:

(1 comment)

File src/mainboard/google/corsola/boardid.c:

https://review.coreboot.org/c/coreboot/+/84342/comment/b472376d_6939dffe?usp... :
PS6, Line 118: 	if (cached_sku_code == CROS_SKU_UNPROVISIONED ||
             : 	    cached_sku_code == CROS_SKU_UNKNOWN) {
             : 		printk(BIOS_WARNING, "SKU code from EC: 0x%x\n", cached_sku_code);
             : 
             : 		if (CONFIG(BOARD_GOOGLE_STARYU_COMMON)) {
             : 			if (get_cpu_id() == MTK_CPU_ID_MT8186T) {
             : 				/* Reserve last 4 bits to report PANEL_ID */
             : 				cached_sku_code = 0x7FFFFEF0UL | panel_id();
             : 			} else {
             : 				cached_sku_code = 0x7FFFFFF0UL | panel_id();
             : 			}
             : 		} else if (get_cpu_id() == MTK_CPU_ID_MT8186T &&
             : 			  !CONFIG(BOARD_GOOGLE_VOLTORB) &&
             : 			  !CONFIG(BOARD_GOOGLE_SQUIRTLE)) {
             : 			/*
             : 			* Distinguish MT8186T from MT8186 to select different device trees
             : 			* in the payload. Voltorb/Squirtle are exception here, because right now
             : 			* they use 0x7FFFFFFF in the DTS compatible string. We'll need to change
             : 			* that to 0x7FFFFEFF in kernel before the exception can be dropped.
             : 			*/
             : 			cached_sku_code = CROS_SKU_UNPROVISIONED_MT8186T;
             : 		}
             : 	}
> or […]

````
cached_sku_code = (CROS_SKU_UNPROVISIONED & ~0x10F) | soc_type << 16 | panel << 0;
````

Or we can use the SETBITFIELD APIs to modify the sku_code to make it easier to read.