Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 53:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35864/51//COMMIT_MSG Commit Message:
PS51: Some lines are too long.
https://review.coreboot.org/c/coreboot/+/35864/51//COMMIT_MSG@8 PS51, Line 8: Maybe move all the tested/untested working/not working statements to Documentation, so as to avoid redundancy.
https://review.coreboot.org/c/coreboot/+/35864/51//COMMIT_MSG@9 PS51, Line 9: - Board port can be 100 % Open Source. I fear this might confuse people into thinking no proprietary software runs on the mainboard, which isn't true.
https://review.coreboot.org/c/coreboot/+/35864/51//COMMIT_MSG@12 PS51, Line 12: black Please indent this two spaces to the right, so that it is aligned with the previous sentence.
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le... PS51, Line 30: Is there anything that has *not* been tested?
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le... PS51, Line 45: Sometimes it takes several second to run coreboot. Just wait for it "several" is not what I would expect 20 seconds to be like.