28 Oct
2019
28 Oct
'19
12:57 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35992 )
Change subject: nb/intel/gm45: Add C_ENVIRONMENT_BOOTBLOCK support ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35992/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35992/5//COMMIT_MSG@12 PS5, Line 12: is used.
You mean, if for instance, somebody changes base addresses? […]
Just one more thought on this, nothing that must change right now: If base addresses would really change, does it hurt to write the register while the resource is enabled?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35992
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f59736cb54377973215f35e35d2cbcd1d82c374
Gerrit-Change-Number: 35992
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Oct 2019 11:57:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment