Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68741 )
Change subject: mb/google/skyrim/var/winterhold: Update touchscreen devicetree setting ......................................................................
mb/google/skyrim/var/winterhold: Update touchscreen devicetree setting
Update touchscreen setting. ELAN900C is the I2C over hid device with slave address 0x10. MELF0410 is the pure I2C device with slave address 0x34. The LCD team verification result is on b/251378772 comment#11.
BUG=b:251378772 TEST=Build/boot ChromeOS on winterhold, ensure touchscreen is functional.
Signed-off-by: EricKY Cheng ericky_cheng@compal.corp-partner.google.com Change-Id: I568346d2abc39d9427e49c3b21f38db0184b8b44 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68741 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Van Patten timvp@google.com --- M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 1 file changed, 28 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Van Patten: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index 900cd23..ab0bda2 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -86,8 +86,8 @@ end # I2C0 device ref i2c_1 on chip drivers/i2c/hid - register "generic.hid" = ""GDIX0000"" - register "generic.desc" = ""Goodix Touchscreen"" + register "generic.hid" = ""ELAN900C"" + register "generic.desc" = ""ELAN Touchscreen"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)" register "generic.probed" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" @@ -100,11 +100,11 @@ register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" - device i2c 5d on end + device i2c 10 on end end chip drivers/i2c/generic - register "hid" = ""ELAN0001"" - register "desc" = ""ELAN Touchscreen"" + register "hid" = ""MELF0410"" + register "desc" = ""Melfas Touchscreen"" register "probed" = "1" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_29)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" @@ -116,7 +116,7 @@ register "stop_off_delay_ms" = "2" register "has_power_resource" = "1" register "disable_gpio_export_in_crs" = "1" - device i2c 10 on end + device i2c 34 on end end chip drivers/generic/gpio_keys register "name" = ""PENH""