Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62960 )
Change subject: [Add slopes, enable rth and energyreport] ......................................................................
Patch Set 1:
(6 comments)
File src/soc/intel/alderlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144357): https://review.coreboot.org/c/coreboot/+/62960/comment/34d7abde_1f844a76 PS1, Line 725: s_cfg->C1StateAutoDemotion = !config->disable_c1_state_auto_demotion; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144357): https://review.coreboot.org/c/coreboot/+/62960/comment/cd480e3f_a0b9438f PS1, Line 727: s_cfg->RaceToHalt = 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144357): https://review.coreboot.org/c/coreboot/+/62960/comment/5d62a71c_5750c23e PS1, Line 728: s_cfg->ImonSlope[0] = 143; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144357): https://review.coreboot.org/c/coreboot/+/62960/comment/ab994683_6bd91fd2 PS1, Line 729: s_cfg->ImonSlope[1] = 103; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144357): https://review.coreboot.org/c/coreboot/+/62960/comment/3610a838_b8b4026f PS1, Line 730: s_cfg->VccInAuxImonSlope = 111; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144357): https://review.coreboot.org/c/coreboot/+/62960/comment/d3344eab_ae2471df PS1, Line 730: s_cfg->VccInAuxImonSlope = 111; please, no spaces at the start of a line