[coreboot-gerrit] [XL] Change in coreboot[master]: vendorcode/intel: Add edk2-stable202302 support

[Arthur Heymans (Code Review)]

Attention is currently required from: Felix Singer, Kapil Porwal, Meera Ravindranath, Paul Menzel, Ronak Kanabar, Sridhar Siricilla, Subrata Banik, Tarun Tuli.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75663?usp=email )

Change subject: vendorcode/intel: Add edk2-stable202302 support
......................................................................

Patch Set 4:

(1 comment)

File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:

https://review.coreboot.org/c/coreboot/+/75663/comment/85b8a865_30f16a15 :
PS4, Line 208: #error You need to implement this struct for x86_64 FSP
             : #endif
             :
> Ideally, it should go there, but if we want to try out 32 bit bootloader, then we will miss the flexibility when FSP 2.4 spec is enabled. Hence, I am suggesting outside of *x86_32 flag. Also, we can remove *x86_32 flag from this file also clears the air. WDYT?

Coreboot can run in 64bit mode with a 32bit FSP by dropping to 32bit mode before calling FSP. You want to make sure that PLATFORM_USES_FSP2_X86_32 is selected when that is the case which is what this error achieves. I guess that FSP mode can be parses from the header on newer revisions? Maybe you can move this error message from C code to makefile?