[coreboot-gerrit] Change in coreboot[master]: soc/skylake: Enable DCI depending on devicetree configuration

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43846 )

Change subject: soc/skylake: Enable DCI depending on devicetree configuration
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43846/2/src/soc/intel/skylake/chip.... 
File src/soc/intel/skylake/chip.c:

https://review.coreboot.org/c/coreboot/+/43846/2/src/soc/intel/skylake/chip.... 
PS2, Line 340: dev = pcidev_path_on_root(PCH_DEVFN_USBOTG);
             : 	if (dev) {
             : 		if (!xdci_can_enable())
             : 			dev->enabled = 0;
             : 		params->XdciEnable = dev->enabled;
             : 	} else {
             : 		params->XdciEnable = 0;
             : 	}
XdciEnable is controlled here already but this could be simplified...

dev = pcidev_path_on_root(PCH_DEVFN_USBOTG);
dev->enabled = dev && dev->enabled && xdci_can_enable();
params->XdciEnable = dev->enabled;