Attention is currently required from: Malik Hsu, Paul Menzel, Casper Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56923 )
Change subject: mb/google/brya/variants/primus: config G2 touchscreen
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56923/comment/66cb678a_dcd29ab9
PS2, Line 7: config G2 touchscreen
suggestion:
`mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity`
https://review.coreboot.org/c/coreboot/+/56923/comment/c934049d_28a599d8
PS2, Line 9: touchscreen spec
Please add the name and revision of the spec.
It was just a typo, using the incorrect polarity on the reset GPIO
https://review.coreboot.org/c/coreboot/+/56923/comment/b36d8421_6c6945e9
PS2, Line 13: TEST=build coreboot and touchscreen works
Before it didn’t?
not if the reset GPIO polarity was backwards 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56923
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb
Gerrit-Change-Number: 56923
Gerrit-PatchSet: 2
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 12 Aug 2021 14:21:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment