Attention is currently required from: Marc Jones, Nico Huber, Julius Werner, Patrick Rudolph.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45208 )
Change subject: console: Allow configuring log level through CBFS
......................................................................
Patch Set 17:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45208/comment/e64fc822_55dc7254
PS4, Line 18: entry is added.
Yes, the VPD solution may be less bad on x86. […]
I'll leave the eierlegende Wollmilchsau (https://de.wikipedia.org/wiki/Eierlegende_Wollmilchsau) - in this case, a generic binary configuration mechanism that works in low-SRAM pre-ram environments with hard to access SPI storage - for somebody else to implement.
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/45208/comment/6b64977f_c7aa2e9f
PS12, Line 71: SLOW_CONSOLE_LOGLEVEL_7
https://review.coreboot. […]
Following Julius' feedback the separate slow console option has been removed entirely
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/45208/comment/64362faa_42532b59
PS14, Line 43: config OPTIONAL_SLOW_CONSOLE
nit: In line with the suggestion of merging all this into the "main" loglevel, I'd consider just ren […]
I dislike options so now that we cut down on the code, I made it a default behavior.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f1f5c45e5ea889176d04e0db438ca2aa7c536ee
Gerrit-Change-Number: 45208
Gerrit-PatchSet: 17
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Greg Edelston
gredelston@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 12 Jul 2021 16:53:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment