Attention is currently required from: YH Lin, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Eric Lai, Zhuohao Lee, Raihow Shi, Felix Held.
Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63080 )
Change subject: mb/google/brask/variants/moli: update overridetree for moli
......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/google/brya/variants/moli/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63080/comment/61fbcaad_5aeffab2
PS7, Line 8: option STORAGE_NVME 0
: option STORAGE_EMMC 1
Reopen this thread. I still don't get the answer in the b/220039297. […]
Hi Zhuohao,
To clarify -
1. Both eMMC connector and SSD connctor are always populated on MB design, we don't seperate MB by storage option.
2. The system only supports either eMMC or SSD according to MP SKU configuation. ODM will base on MP SKU config to set CBI value before shipment.
3. RMA center can't identify the repaired MB is eMMC or SSD boot.
Thansk!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63080
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If83031edcd90ea746704590765102b9b0dee03c1
Gerrit-Change-Number: 63080
Gerrit-PatchSet: 17
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 15 Apr 2022 01:08:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-MessageType: comment