Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36260 )
Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................
ec/google/chromeec/acpi: Drop wrong _ADR object
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36260 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index c521a3a..9c0fa68 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -40,7 +40,6 @@ Device (ECMM) { Name (_HID, EISAID ("PNP0C02")) Name (_UID, 4) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -64,7 +63,6 @@ Device (ECUI) { Name (_HID, EISAID ("PNP0C02")) Name (_UID, 3) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -109,7 +107,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -137,7 +134,6 @@ Device (PS2K) // Keyboard { Name (_UID, 0) - Name (_ADR, 0) Name (_HID, "GOOG000A") Name (_CID, Package() { EISAID("PNP0303"), EISAID("PNP030B") } )