Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43277 )
Change subject: mb/mainboard/dedede: update GPIO table for Boten ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43277/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/43277/5/src/mainboard/google/dedede... PS5, Line 18: PAD_CFG_GPO(GPP_D13, 1, PLTRST), Is it required to be enabled at the boot itself?
https://review.coreboot.org/c/coreboot/+/43277/5/src/mainboard/google/dedede... PS5, Line 34: /* E17 : HDMI_DDC_SCL */ : PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), : /* E18 : HDMI_DDC_SDA */ : PAD_CFG_NF(GPP_E18, NONE, DEEP, NF1), These 2 GPIOs are configured as required in the following coreboot CL: https://review.coreboot.org/c/coreboot/+/43294. So you can remove them from the override configuration.