[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8189: Add a stub implementation of MT8189 SoC

[Vince Liu (Code Review)]

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.

Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85616?usp=email )

Change subject: soc/mediatek/mt8189: Add a stub implementation of MT8189 SoC
......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85616/comment/ff64d521_d940760c?usp... :
PS1, Line 10: Also enable UART and ARM arch timer.
> Please provide a brief overview about how MT8189 differs from the previous SoC (either MT8196 or MT8 […]

Done

File src/soc/mediatek/mt8189/include/soc/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/85616/comment/a2bacbf5_e0ca71bb?usp... :
PS1, Line 22: 	/*
            : 	* Since MCUPM uses most of the space, most regions are put in SRAM_L2C below.
            : 	*/
            :
> wrong indent

Done

https://review.coreboot.org/c/coreboot/+/85616/comment/49072caf_d871987d?usp... :
PS1, Line 35: 	/*
            : 	* The needed size can be obtained by:
            : 	*  aarch64-cros-linux-gnu-objdump -x dram.elf | grep memsz
            : 	* To move the address, dram.elf also needs to be modified accordingly.
            : 	*/
> wrong indent

Done

https://review.coreboot.org/c/coreboot/+/85616/comment/400ed413_1ab6a015?usp... :
PS1, Line 42: 	/*
            : 	* The bootROM needs 4K starting from SRAM_L2C_START so the bootblock starting address
            : 	* is fixed at SRAM_L2C_START + 4K, and the 4K can be reused after bootblock is started.
            : 	* To move the address, gen-bl-img.py also needs to be modified accordingly.
            : 	*/
> wrong indent

Done