build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31428 )
Change subject: mb/google/laser: Disable touch screen device that according to SKU ID ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/phaser/gpio.c:
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 73: if ((sku_id == 1) || (sku_id == 6)) code indent should use tabs where possible
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 73: if ((sku_id == 1) || (sku_id == 6)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 74: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 74: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 75: else code indent should use tabs where possible
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 75: else please, no spaces at the start of a line
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 76: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/31428/6/src/mainboard/google/octopus/variant... PS6, Line 76: return false; please, no spaces at the start of a line