[coreboot-gerrit] Change in coreboot[master]: arch/x86/post.c: Hide cmos_post_code from SMM context

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38370 )

Change subject: arch/x86/post.c: Hide cmos_post_code from SMM context
......................................................................

arch/x86/post.c: Hide cmos_post_code from SMM context

Code in SMM segment using cmos_post_code will give compiler error since
cmos_post_code function is not getting compiled during SMM stage.

Also as per patch discussion, CMOS uses a split IO transaction and it's not
really safe to call cmos_post_code from SMM context. Thus we'll hide the
call for SMM context.

Change-Id: Iffdcccaad48e7ad96e068d07046630fbe4297e65
Signed-off-by: Maulik V Vaghela 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38370
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
---
M src/arch/x86/post.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/arch/x86/post.c b/src/arch/x86/post.c
index 0a20bab..b9cd26b 100644
--- a/src/arch/x86/post.c
+++ b/src/arch/x86/post.c
@@ -21,6 +21,6 @@
    if (CONFIG(POST_IO))
    	outb(value, CONFIG_POST_IO_PORT);

-	if (CONFIG(CMOS_POST))
+	if (CONFIG(CMOS_POST) && !ENV_SMM)
    	cmos_post_code(value);
 }