Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35768 )
Change subject: mb/google/octopus: Create Dood variant ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/dood/gpio.c:
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... PS2, Line 22: static const struct pad_config default_override_table[] = { Just note that LTE specified GPIOs and early gpio table will need to be added later.
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/dood/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... PS2, Line 22: #define EC_ENABLE_KEYBOARD_BACKLIGHT Will Dood need keyboard backlight?
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/dood/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... PS2, Line 55: #| I2C7 | Touchscreen | Dood is clamshell so we don't need I2C0 and I2C7?
https://review.coreboot.org/c/coreboot/+/35768/2/src/mainboard/google/octopu... PS2, Line 110: end And pen?