Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: rework and fix platform detection ......................................................................
Uploaded patch set 8.
(4 comments)
https://review.coreboot.org/c/coreboot/+/35763/7/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35763/7/src/include/device/pci_ids.... PS7, Line 2701: #define PCI_DEVICE_ID_INTEL_SPT_LP_LPC_MASK 0x001f
because of brainf... […]
Done
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_... File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_... PS7, Line 114: },
we generally indent with tabs […]
Done
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_... PS7, Line 126: {
oops... […]
Done
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_... PS7, Line 178: if ((id & platform->lpc_mask) == platform->lpc_base)
right... I forgot the invert in PCI ids... […]
Done