Attention is currently required from: Jamal Wright, Iru Cai, Patrick Rudolph.
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51179 )
Change subject: T440P: Enable FN Lock Inversion
......................................................................
Patch Set 13:
(2 comments)
File src/ec/lenovo/h8/h8.c:
https://review.coreboot.org/c/coreboot/+/51179/comment/aca7a968_c512fdbb
PS13, Line 84: static void fn_lock_swap(int on)
Even the other functions doesn't have much documentation. It would be great if you could add some description here. Your commit message is very nice already. Maybe copy parts from there.
File src/mainboard/lenovo/t440p/cmos.default:
https://review.coreboot.org/c/coreboot/+/51179/comment/58a3826c_78b1aae0
PS13, Line 10: fn_lock_swap=Enable
Shouldn't the default Disabled?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 13
Gerrit-Owner: Jamal Wright
Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Jamal Wright
Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jamal Wright
Crabstorage@getbackinthe.kitchen
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 29 Oct 2022 13:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment