Attention is currently required from: Karthik Ramasubramanian, Paul Menzel, Shelley Chen, Sheng-Liang Pan.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83779?usp=email )
Change subject: mb/google/brox/var/jubilant: Add SAR sensor SX9324
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83779/comment/947dbe0c_64fd6fb7?usp... :
PS7, Line 412: register "ph0_pin" = "{1, 2, 2}"
: register "ph1_pin" = "{2, 1, 2}"
: register "ph2_pin" = "{2, 2, 1}"
: register "ph3_pin" = "{2, 1, 1}"
: register "ph01_resolution" = "1024"
: register "ph23_resolution" = "1024"
: register "startup_sensor" = "1"
: register "ph01_proxraw_strength" = "2"
: register "ph23_proxraw_strength" = "2"
: register "avg_pos_strength" = "256"
: register "cs_idle_sleep" = ""hi-z""
: register "int_comp_resistor" = ""lowest""
: register "input_precharge_resistor_ohms" = "4000"
: register "input_analog_gain" = "1"
: device i2c 28 on
: probe DB_USB DB_1A_LTE
: end
Please document the source for these values in the commit message.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83779?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I629117f20ca513dc0c8eaa91744ad33e162ba4bb
Gerrit-Change-Number: 83779
Gerrit-PatchSet: 8
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 08 Aug 2024 02:58:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org