[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC mt6373 driver

[Yidi Lin (Code Review)]

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85129?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIC mt6373 driver
......................................................................

Patch Set 29:

(2 comments)

File src/soc/mediatek/common/mt6373.c:

https://review.coreboot.org/c/coreboot/+/85129/comment/0350e18e_f779f2a9?usp... :
PS19, Line 270: 	mt6373_enable_vcn33_3(true);
              : 	mt6373_set_vcn33_3_voltage(3300000);
> It is for display.

Put them in the condition of `if (display_init_required())` in mainboard.c.

Please also make sure that the kernel does not rely on this power-on sequence in the FW.

File src/soc/mediatek/mt8196/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/85129/comment/8382a03a_fdd71207?usp... :
PS29, Line 34: romstage-y += ../common/mt6373.c mt6373.c
Please explain why it is needed in romstage and ramstage.