Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 23:
(10 comments)
The r60 data.vbt is exactly the same as t60, so please remove it.
https://review.coreboot.org/c/coreboot/+/35864/23/.tmpconfig.lintmiTEi9 File .tmpconfig.lintmiTEi9:
PS23: Get rid of this.
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 1: ThinkPad Thinkpad
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 3:  I'm still not convinced this image is useful.
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 4: : Untested on boards with external Radeon graphics adapter. If you have such board, proceed at your own risk and document if it does work. It should work, but no one tested it yet. You're saying everything twice here...
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 11: The flash IC is located at the bottom center of the mainboard. Access to the flash chip is blocked by the magnesium frame, so you need to disassemble the entire laptop and remove the mainboard. Note: a Picture of the flash IC's location would be useful. Not a must if you don't want to disassemble to do that.
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 18: I This is documentation, not a blog.
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 17: : I have flashed it correctly using this method: : https://gist.github.com/ArthurHeymans/c5ef494ada01af372735f237f6c6adbe : In config use R60 board instead of X60 something like "This [method](https://.... ) describes a way to install coreboot with vendor firmware still installed on the Lenovo Thinkpad X60, it is reported to also work in Thinkpad R60, with the only difference being the board target you build coreboot for" ?
I update that guide and put it in documentation...
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 24: After installing coreboot all lenovo bios flashing restrictions are lifted. : Flashrom is able to flash updated coreboot.rom without any problems. I'd just state that by default coreboot does not feature flash restrictions like the vendor firmware and therefore flashing firmware internally can be done without problems.
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... PS23, Line 25: updated coreboot.rom "any rom"
https://review.coreboot.org/c/coreboot/+/35864/23/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.png:
PS23: 2M is way too large. reduce to at least 100Kb