Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38454 )
Change subject: mainboard/puff: Fix ACPI tables to advertise correct features ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 30: EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)
This won't be required for Puff. It is based on mode change between laptop <-> tablet mode.
yep, fixed already.
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 45: EC_HOST_EVENT_KEY_PRESSED
This won't be required for Puff. […]
Ah I see.
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 46: EC_HOST_EVENT_MODE_CHANGE
This won't be required for Puff.
.
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 55: EC_HOST_EVENT_BATTERY_SHUTDOWN
I don't think this will be required?
thx i missed one bat case.