Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31609 )
Change subject: soc/intel/icelake: Enable PM timer emulation support
......................................................................
Patch Set 2:
(2 comments)
This seems to be present since Skylake. Why wasn’t it included in the original commit adding support for Ice Lake?
https://review.coreboot.org/#/c/31609/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31609/2//COMMIT_MSG@8
PS2, Line 8:
Could you please give more details? Why is the PM timer needed?
How much time does this add to the boot process?
https://review.coreboot.org/#/c/31609/2//COMMIT_MSG@9
PS2, Line 9: alt/tianocore
What does *alt* stand for?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31609
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fd11e728b7a14f41f08bc39bcd92a42a8aa6cff
Gerrit-Change-Number: 31609
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 12:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment