Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74557 )
Change subject: soc/qualcomm/sc7180: Fix set but unused variables ......................................................................
soc/qualcomm/sc7180: Fix set but unused variables
This fixes clang warnings.
Change-Id: I407da6ec05ef646f61bd81e314fee1b5ea659192 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/qualcomm/sc7180/display/disp.c M src/soc/qualcomm/sc7180/display/dsi_phy.c 2 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/74557/1
diff --git a/src/soc/qualcomm/sc7180/display/disp.c b/src/soc/qualcomm/sc7180/display/disp.c index 4ee6bec..1296cb4 100644 --- a/src/soc/qualcomm/sc7180/display/disp.c +++ b/src/soc/qualcomm/sc7180/display/disp.c @@ -7,9 +7,9 @@ { uint32_t hsync_period, vsync_period, hsync_start_x, hsync_end_x; uint32_t display_hctl, hsync_ctl, display_vstart, display_vend; - uint32_t mdss_version;
- mdss_version = read32(&mdss_hw->hw_version); + /* Is this necessary ? */ + read32(&mdss_hw->hw_version); hsync_period = edid->mode.ha + edid->mode.hbl; vsync_period = edid->mode.va + edid->mode.vbl; hsync_start_x = edid->mode.hbl - edid->mode.hso; diff --git a/src/soc/qualcomm/sc7180/display/dsi_phy.c b/src/soc/qualcomm/sc7180/display/dsi_phy.c index a7b04a8..a43470d 100644 --- a/src/soc/qualcomm/sc7180/display/dsi_phy.c +++ b/src/soc/qualcomm/sc7180/display/dsi_phy.c @@ -536,8 +536,6 @@ static unsigned long dsi_phy_calc_clk_divider(struct dsi_phy_configtype *phy_cfg) { bool div_found = false; - uint32_t m_val = 1; - uint32_t n_val = 1; uint32_t div_ctrl = 0; uint32_t reg_val = 0; uint32_t pll_post_div = 0; @@ -556,9 +554,6 @@
dsi_phy_mnd_divider(phy_cfg);
- m_val = phy_cfg->pclk_divnumerator; - n_val = phy_cfg->pclk_divdenominator; - /* Desired clock in MHz */ desired_bitclk_hz = (uint64_t)phy_cfg->desired_bitclk_freq;