Attention is currently required from: Eric Lai, Paul Menzel, Subrata Banik.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 12:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81773/comment/fdc9a161_1e2e4d66 :
PS9, Line 9: Add RT5645 AMP support.
As it’s C code, can’t you guard the device specific parts by an if statement?
5650 and 5645 are in the same series, different from 5663.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81773/comment/a83cb5cb_14fcfd10 :
PS11, Line 11: ALC5650
So why name the directory *rt5645*? Please add a comment in the commit message.
The kernel driver of 5650 is written in rt5645.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 12
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 15 Apr 2024 09:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-MessageType: comment