Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Paul Menzel.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76091/comment/7d323f38_1069f4f4 :
PS2, Line 7: mb/google/skyrim/variants/baseboard:Update system_configuration
Maybe more specific: […]
Done
https://review.coreboot.org/c/coreboot/+/76091/comment/b4068ae3_7ae62d95 :
PS2, Line 7: :Update
Please add a space.
Done
https://review.coreboot.org/c/coreboot/+/76091/comment/c7e90aed_70939277 :
PS2, Line 10: "
Is that quote in there?
Done
https://review.coreboot.org/c/coreboot/+/76091/comment/2e2b37ae_ef8e7da0 :
PS2, Line 12: that is not needed
Is that causing some delay, or it’s just for correctness?
Done
https://review.coreboot.org/c/coreboot/+/76091/comment/4aad57d1_55df29a2 :
PS2, Line 15: TEST=Confirm extra message is not sent in serial log.
Could you please paste the message that is not sent?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76091?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Gerrit-Change-Number: 76091
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 18:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment