[coreboot-gerrit] Change in ...coreboot[master]: src/arch: An upgrade of SMBIOS to latest version 3.2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31863 )

Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/31863/6/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/31863/6/src/arch/x86/smbios.c@560 
PS6, Line 560: 		&& leaf_b.ecx == 0x0000 && leaf_b.edx == 0x0000) {
I guess you have to check the eax result of cpuid leaf 0. If there
is no function for that in coreboot yet, it's worth to add it to
`arch/x86/cpuid`.

"If a value entered for CPUID.EAX is higher than the maximum input
  value for basic or extended function for that processor then the
  data for the highest basic information leaf is returned."