Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47903 )
Change subject: Makefile.inc: Alloc .bss.* sections for "struct" file type ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Thanks, I think this is generally a good fix to have. However, I do somewhat question what you are doing there with SDRAM params on asurada in a more general sense. There's no big rule that says you *have* to store SDRAM params in a separate file no matter how trivial they are. The reason we do that is to avoid additional loading times for loading all the params when we only need one of them, but that only applies if they're sufficiently big to make this a time save. If your whole SDRAM params consist of a single enum, then please just hardcode that table rather than storing it in separate files (where storing the hardcoded filename of that file would take up more space than the enum value itself).
https://review.coreboot.org/c/coreboot/+/47903/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47903/4/Makefile.inc@340 PS4, Line 340: .bss.* nit: does .bss* also work (so it would include a section just called ".bss", in case -fdata-sections wasn't on for some reason)?