Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Nico Huber, Paul Menzel, TangYiwei, Tim Chu.
Ziang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75738?usp=email )
Change subject: soc/intel/xeon_sp: Fix HEST table length
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Just noticed there is a more advanced (code-wise but not wrt. the commit message) […]
Thanks for pointing out, looks like in PR:69500 some extra changes getting rid of void pointers have been added, but IMHO it is not necessary because void* pointers are basically everywhere in ACPI/SMBIOS...
I mean, maybe the void*-pointer-not-portable issue is out of the scope of this patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ff1e8e24612b7356772d582ff9a7e53863419db
Gerrit-Change-Number: 75738
Gerrit-PatchSet: 2
Gerrit-Owner: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jeff Li
lijinfeng01@inspur.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: TangYiwei
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 02:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment