Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jérémy Compostella, Kapil Porwal, Pranava Y N.
Hello Boris Mittelberg, Caveh Jalali, Kapil Porwal, Pranava Y N, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85765?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Kapil Porwal, Verified+1 by build bot (Jenkins)
Change subject: ec/google/chromeec: Add function to detect barrel charger ......................................................................
ec/google/chromeec: Add function to detect barrel charger
This commit introduces a new function, google_chromeec_is_barrel_charger_present(), which checks if a barrel charger is present.
The function uses the following logic to determine if a barrel charger is present:
- If both a barrel charger and USB-C PD are present, then the barrel charger takes precedence over USB-C PD. As a result, google_chromeec_is_usb_pd_attached() will return false. This logic can be used to deterministically say if a barrel charger is present even when both a barrel charger and USB-C PD are attached.
- If an AC charger is detected and USB-C PD is not present, then a barrel charger must be present.
This change allows the EC to accurately detect the presence of a barrel charger, even when a USB-C PD charger is also attached.
BUG=b:377798581 TEST=Able to read the charger status correctly while booting google/fatcat.
Experiment #1: - USB-C PD Attached = yes - Barrel Attached = No - Charger Detected = Yes
``` fatcat-rev257 ~ # cbmem -c | grep -5 "ac_charger_present" [INFO ] ac_charger_present: yes [INFO ] usb_pd_present: yes [INFO ] baseboard_devtree_update: Barrel Absent ```
Experiment #2: - USB-C PD Attached = No - Barrel Attached = Yes - Charger Detected = Yes
``` [INFO ] ac_charger_present: yes [INFO ] usb_pd_present: no [INFO ] baseboard_devtree_update: Barrel Present ```
Experiment #3: - USB-C PD Attached = Yes - Barrel Attached = Yes - Charger Detected = Yes
``` [INFO ] ac_charger_present: yes [INFO ] usb_pd_present: no [INFO ] baseboard_devtree_update: Barrel Present ```
Experiment #4: - USB-C PD Attached = No - Barrel Attached = No - Charger Detected = No
``` [INFO ] ac_charger_present: no [INFO ] usb_pd_present: no [INFO ] baseboard_devtree_update: Barrel Absent ```
Change-Id: I9644f0dec057f95bb0a22cdc18edc1a0234ee3a9 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/85765/2