[coreboot-gerrit] [S] Change in libgfxinit[main]: gma ironlake: Move FDI override into Connectors.Prepare()

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/83603?usp=email )

Change subject: gma ironlake: Move FDI override into Connectors.Prepare()
......................................................................

gma ironlake: Move FDI override into Connectors.Prepare()

Change-Id: Iac5334e91b1e706dca21e74845a3227c3b9b6503
Signed-off-by: Nico Huber 
---
M common/hw-gfx-gma-config_helpers.adb
M common/ironlake/hw-gfx-gma-connectors.adb
2 files changed, 28 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/03/83603/1

diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb
index 5a3ba7e..82f54b6 100644
--- a/common/hw-gfx-gma-config_helpers.adb
+++ b/common/hw-gfx-gma-config_helpers.adb
@@ -14,7 +14,6 @@

with HW.GFX.GMA.Connector_Info;
 with HW.GFX.GMA.DP_Info;
-with HW.GFX.GMA.Registers;

with HW.Debug;

@@ -178,25 +177,12 @@
          Port_Cfg.Mode.H_Visible = Port_Cfg'Old.Mode.H_Visible and
          Port_Cfg.Mode.V_Visible = Port_Cfg'Old.Mode.V_Visible
    is
-      FDI_TX_CTL_FDI_TX_ENABLE : constant := 1 * 2 ** 31;
-      Enabled : Boolean;
    begin
       Port_Cfg.FDI.Receiver_Caps.Max_Link_Rate    := DP_Bandwidth_2_7;
       Port_Cfg.FDI.Receiver_Caps.Max_Lane_Count   :=
          Config.FDI_Lane_Count (Port_Cfg.Port);
       Port_Cfg.FDI.Receiver_Caps.Enhanced_Framing := True;

-      if Config.Has_FDI_C and then Port_Cfg.Port = DIGI_C then
-         -- if DIGI_D enabled: (FDI names are off by one)
-         Registers.Is_Set_Mask
-           (Register => Registers.FDI_TX_CTL_C,
-            Mask     => FDI_TX_CTL_FDI_TX_ENABLE,
-            Result   => Enabled);
-         if Enabled then
-            Port_Cfg.FDI.Receiver_Caps.Max_Lane_Count := DP_Lane_Count_2;
-         end if;
-      end if;
-
       DP_Info.Preferred_Link_Setting (Port_Cfg.FDI, Port_Cfg.Mode, Success);
    end Configure_FDI_Link;

diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb
index c1bec22..a3ce7b0 100644
--- a/common/ironlake/hw-gfx-gma-connectors.adb
+++ b/common/ironlake/hw-gfx-gma-connectors.adb
@@ -14,6 +14,8 @@
 --

with HW.GFX.GMA.Config;
+with HW.GFX.GMA.DP_Info;
+with HW.GFX.GMA.Registers;
 with HW.GFX.GMA.Panel;
 with HW.GFX.GMA.Connectors.EDP;
 with HW.GFX.GMA.Connectors.FDI;
@@ -44,8 +46,33 @@
       Port_Cfg : in out Port_Config;
       Success  :    out Boolean)
    is
+      -- Override lane count for FDI_B if FDI_C is used
+      procedure Override_FDI_Link
+      with
+         Post => Port_Cfg.Mode = Port_Cfg'Old.Mode
+      is
+         FDI_TX_CTL_FDI_TX_ENABLE : constant := 1 * 2 ** 31;
+         Enabled : Boolean;
+      begin
+         if Config.Has_FDI_C and then Port_Cfg.Port = DIGI_C then
+            -- if DIGI_D enabled: (FDI names are off by one)
+            Registers.Is_Set_Mask
+              (Register => Registers.FDI_TX_CTL_C,
+               Mask     => FDI_TX_CTL_FDI_TX_ENABLE,
+               Result   => Enabled);
+            if Enabled then
+               Port_Cfg.FDI.Receiver_Caps.Max_Lane_Count := DP_Lane_Count_2;
+            end if;
+         end if;
+
+         DP_Info.Preferred_Link_Setting (Port_Cfg.FDI, Port_Cfg.Mode, Success);
+      end Override_FDI_Link;
    begin
-      Success := True;
+      if Port_Cfg.Is_FDI then
+         Override_FDI_Link;
+      else
+         Success := True;
+      end if;
    end Prepare;

----------------------------------------------------------------------------